Prep for multiple container image stores #695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Rough draft of how I envision this might work. One notable thing is that this version does not use async at all, however I expect that will probably become necessary when we add future backends (it started to creep in over in #215). Things were starting to get unwieldy here with async because of things like |
cgwalters
reviewed
Jul 16, 2024
jeckersb
force-pushed
the
backend_v2
branch
2 times, most recently
from
0c57786
to
5bbc98d
Compare
jeckersb
changed the title
|
Notable changes since last version:
|
jeckersb
commented
Jul 23, 2024
cgwalters
approved these changes
Jul 23, 2024
For now, this is effectively a no-op as it only implements a store for the current ostree container implementation. Beyond some minor code movement and plumbing, this also only handles the store implementation backing the `bootc status` command. Additional image store functionality (check, pull, delete, etc.) will be added in future changes in order to keep things smaller and more manageable. Signed-off-by: John Eckersberg <[email protected]>
|
Ok, rebased, added the alias, and added a test. |
cgwalters
pushed a commit
to cgwalters/bootc
that referenced
this pull request
Nov 5, 2024
….5.13 build(deps): bump clap from 4.5.11 to 4.5.13
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For now, this is effectively a no-op as it only implements a store for
the current ostree container implementation.
Beyond some minor code movement and plumbing, this also only handles
the store implementation backing the
bootc statuscommand.Additional image store functionality (check, pull, delete, etc.) will
be added in future changes in order to keep things smaller and more
manageable.